Move font-awesome import to app.global.css

so we don't need npm dependency in app/package.json
daddycai · Nov 1, 2016 · b637006 · b637006
1 parent 2c0dce9
commit b637006
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/app/app.global.css b/app/app.global.css
@@ -1,3 +1,5 @@
+@import "~font-awesome/css/font-awesome.css";
+
 body {
   position: relative;
   color: white;

diff --git a/app/app.html b/app/app.html
@@ -3,8 +3,6 @@
   <head>
     <meta charset="utf-8">
     <title>Hello Electron React!</title>
-    <link rel="stylesheet" href="node_modules/font-awesome/css/font-awesome.min.css" />
-
     <script>
       (function() {
         if (!process.env.HOT) {

diff --git a/app/package.json b/app/package.json
@@ -11,7 +11,6 @@
   },
   "license": "MIT",
   "dependencies": {
-    "font-awesome": "^4.6.3",
     "source-map-support": "^0.4.3"
   }
 }
diff --git a/webpack.config.electron.js b/webpack.config.electron.js
@@ -55,7 +55,6 @@ export default validate(merge(baseConfig, {
   },
 
   externals: [
-    'font-awesome',
     // 'source-map-support'
   ]
 }));