Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container logic from docker-compose.yml to Dockerfile #49

Closed
dadatuputi opened this issue Jan 26, 2023 · 4 comments
Closed

Move container logic from docker-compose.yml to Dockerfile #49

dadatuputi opened this issue Jan 26, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dadatuputi
Copy link
Owner

Much of the command mess in the compose file should be in their own Dockerfiles that extends the base image. Easily done with caddy as of 837c1fc, however watchtower won't pull updates to the base image (see containrrr/watchtower#1401).

Alternatives to watchtower, cron?

  • It would require a simple script and an extra step during installation.
  • Existing users who blindly git pull will miss that step
@dadatuputi dadatuputi added the enhancement New feature or request label Jan 26, 2023
@dadatuputi dadatuputi self-assigned this Jan 26, 2023
@dadatuputi
Copy link
Owner Author

This seems like the most sensible approach, although clunky, until watchtower or some other process is capable of rebuilding images when base images are updated.

dadatuputi added a commit that referenced this issue Apr 4, 2023
* use caddy submodule test
@dadatuputi
Copy link
Owner Author

Giving the CI -> docker repository (ghcr) a try with caddy (#57). Used https://www.howtogeek.com/devops/how-to-set-up-automatic-builds-for-docker-images-on-github/ and https://www.flypenguin.de/2021/07/30/auto-rebuild-docker-images-if-base-image-changes-using-github-actions/ to throw something together in Github actions.

@dadatuputi
Copy link
Owner Author

#58 is merged, now just need to split countryblock into its own project.

@dadatuputi
Copy link
Owner Author

Moved 3 containers to their own project/repo:

Each has Github actions in place that will

  • Build and publish the docker image on each push or merged pull request
  • Check the base image daily for a new version, and rebuild and publish when there is a new base image version

This should keep these containers up to date, and with watchtower running, keep everything perpetually updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant