Skip to content

Add compatibility for _extract_signature_elements to nested typing hints #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add compatibility for _extract_signature_elements to nested typing hints #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pyment/docstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,12 +1532,12 @@ def _extract_signature_elements(self, txt):
elem_idx = 0
reading = 'param'
elems[elem_idx] = {'type': '', 'param': '', 'default': ''}
inside = None
inside = []
end_inside = {'(': ')', '{': '}', '[': ']', "'": "'", '"': '"'}
for c in txt[start:end_start]:
if (inside and end_inside[inside] != c) or (not inside and c in end_inside.keys()):
if not inside:
inside = c
if (inside and end_inside.get(inside[-1]) != c) or (not inside and c in end_inside.keys()):
if c in end_inside.keys():
inside.append(c)
if reading == 'type':
elems[elem_idx]['type'] += c
elif reading == 'default':
Expand All @@ -1546,8 +1546,8 @@ def _extract_signature_elements(self, txt):
# FIXME: this should not happen!
raise Exception("unexpected nested element after "+str(inside)+" while reading "+reading)
continue
if inside and c == end_inside[inside]:
inside = None
if inside and c == end_inside[inside[-1]]:
inside.pop()
if reading == 'param':
if c not in ': ,=':
elems[elem_idx]['param'] += c
Expand Down