Skip to content

Commit

Permalink
ignore mail params with empty data in csv export (#465)
Browse files Browse the repository at this point in the history
  • Loading branch information
solverat authored Aug 12, 2024
1 parent 0be1a0c commit 1192899
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- **[SECURITY FEATURE]** Add [friendly captcha field](/docs/03_SpamProtection.md#friendly-captcha)
- **[SECURITY FEATURE]** Add [cloudflare turnstile](/docs/03_SpamProtection.md#cloudflare-turnstile)
- **[BUGFIX]** Use Pimcore AdminUserTranslator for Editable Dialog Box [#450](https://github.com/dachcom-digital/pimcore-formbuilder/issues/450)
- **[BUGFIX]** CSV Export: Ignore mail params with empty data [#461](https://github.com/dachcom-digital/pimcore-formbuilder/issues/461)
- **[IMPROVEMENT]** Improve json response success message behaviour [#416](https://github.com/dachcom-digital/pimcore-formbuilder/issues/416)
- **[IMPROVEMENT]** [#458](https://github.com/dachcom-digital/pimcore-formbuilder/pull/458)
- Allow to modify FormType options via `FORM_TYPE_OPTIONS` event
Expand Down
4 changes: 4 additions & 0 deletions src/Controller/Admin/ExportController.php
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ private function extractMailParams(Email\Log $log, FormDefinitionInterface $form
}
}

if (!array_key_exists('data', $mailParam)) {
continue;
}

if (!in_array($displayKeyName, $mailHeader, true)) {
$mailHeader[] = $displayKeyName;
}
Expand Down

0 comments on commit 1192899

Please sign in to comment.