Merged
Conversation
The code uses a custom timer for all timer functions, however, there is a built in SysTick timer that could be used. By moving over the built in timer, we can save some Flash that is used for setup and management of the custom timer.
Record current sizes. No code changes. Reviewed and it is correct.
Implemented Phase 2, performed a code review, and a clean compile. Unable to test as HW not available.
Implemented Phase 3, code reviewed and compiled. Can't test as HW not available.
Implemented the documentation changes and archived the migration spec.
Owner
Author
|
Migrate 10 ms scheduler from TIM1 to SysTick (reduce flash)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code uses a custom timer to manage time based events, however, the built in SysTick timer could be used. Moving to that timer will save Flash that is used to configure and use the custom timer.