Skip to content

Commit

Permalink
[lldb] Remove --rerun-all-issues as its functionality no longer exists
Browse files Browse the repository at this point in the history
The logic behind --rerun-all-issues was removed when we switched to LIT
as the test driver. This patch just removes the dotest option and
corresponding entry in configuration.py.
  • Loading branch information
JDevlieghere committed Aug 21, 2020
1 parent 17cd344 commit d3a49b0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
3 changes: 0 additions & 3 deletions lldb/packages/Python/lldbsuite/test/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@
capture_path = None
replay_path = None

# Test rerun configuration vars
rerun_all_issues = False

# The names of all tests. Used to assert we don't have two tests with the
# same base name.
all_tests = set()
Expand Down
4 changes: 0 additions & 4 deletions lldb/packages/Python/lldbsuite/test/dotest.py
Original file line number Diff line number Diff line change
Expand Up @@ -416,10 +416,6 @@ def parseOptionsAndInitTestdirs():

if args.replay_path:
configuration.replay_path = args.replay_path

# rerun-related arguments
configuration.rerun_all_issues = args.rerun_all_issues

if args.lldb_platform_name:
configuration.lldb_platform_name = args.lldb_platform_name
if args.lldb_platform_url:
Expand Down
10 changes: 0 additions & 10 deletions lldb/packages/Python/lldbsuite/test/dotest_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,16 +244,6 @@ def create_parser():
help='(Windows only) When LLDB crashes, display the Windows crash dialog.')
group.set_defaults(disable_crash_dialog=True)

# Re-run related arguments
group = parser.add_argument_group('Test Re-run Options')
group.add_argument(
'--rerun-all-issues',
action='store_true',
help=('Re-run all issues that occurred during the test run '
'irrespective of the test method\'s marking as flakey. '
'Default behavior is to apply re-runs only to flakey '
'tests that generate issues.'))

# Remove the reference to our helper function
del X

Expand Down

0 comments on commit d3a49b0

Please sign in to comment.