fix: deadlock in std_log_impl macro on write failure #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std_log_impl macro, deadlocks when a write operation fails. This occurs because the stream lock is still held when fallback_on_error attempts to write the error message.
The fix modifies the macro to properly scope the stream lock:
result?Before:
After:
This prevents the deadlock by ensuring the stream lock is always released before any error handling occurs through fallback_on_error.
Fixes #150
Validation: