Skip to content

Fix memory leaks from uncleaned event listeners #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacwright
Copy link
Member

Summary

  • Add proper cleanup for event listeners in error paths during document creation
  • Clear all event signal subscribers in close() method to prevent memory leaks
  • Ensure unsubscriber is called even if adding document to map fails

Test plan

  • Existing client tests pass
  • Verified event listeners are properly cleaned up in all code paths

🤖 Generated with Claude Code

- Add proper cleanup for event listeners in error paths during document creation
- Clear all event signal subscribers in close() method to prevent memory leaks
- Ensure unsubscriber is called even if adding document to map fails

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant