Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New Page" option for 404 #1006

Closed
wants to merge 3 commits into from
Closed

Add "New Page" option for 404 #1006

wants to merge 3 commits into from

Conversation

sorat0mo
Copy link
Contributor

@sorat0mo sorat0mo commented Jul 14, 2022

Improvement on #1004

This should work, but it cannot distinguish new pages from new posts, i.e. When you try "abc.github.io/2022-07-14-abcde" it will just direct you to create a file called "2022-07-14-abcde" in root.

Example when the page does not exist (Notice the text in red boxes)

20220714_00001

Karsten Ng added 3 commits July 14, 2022 06:48
This should work, but it cannot distinguish new pages from new posts, i.e. When you try "abc.github.io/2022-07-14-abcde" it will just direct you to create a file called "2022-07-14-abcde" in root.
@daattali
Copy link
Owner

Thanks @sorat0mo , I appreciate the effort. But for the sake of not bloating the codebase with too many esoteric features, I prefer not to merge this feature. "Edit this page" is something that can be used by anyone who goes to your website when they see an issue and they want to help you fix it; "New page" button is only for yourself and it sounds like a bit of a strange use case. I prefer not to add code/features that are not going to be very popular.

@daattali daattali closed this Jul 14, 2022
@sorat0mo sorat0mo deleted the tryNewPage branch July 14, 2022 09:30
adam-abed-abud pushed a commit to adam-abed-abud/adam-abed-abud.github.io that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants