Skip to content

fix(plugin-history-sync): add decode interface to Config and support route: string[]#560

Merged
tonyfromundefined merged 7 commits intomainfrom
history-sync-plugin-decode
Jan 22, 2025
Merged

fix(plugin-history-sync): add decode interface to Config and support route: string[]#560
tonyfromundefined merged 7 commits intomainfrom
history-sync-plugin-decode

Conversation

@tonyfromundefined
Copy link
Member

@tonyfromundefined tonyfromundefined commented Jan 21, 2025

  • Resolves an issue that prevented the decode() interface from being used in @stackflow/config
  • Resolves an issue that prevented the route: string[] interface from being used in @stackflow/config.

Breaking Change

  • change field name ActivityDefinition.path to ActivityDefinition.route

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 8ce1fcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@stackflow/plugin-history-sync Patch
@stackflow/react Patch
@stackflow/link Patch
@stackflow/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jan 22, 2025 7:18am

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz@stackflow/demo

yarn add https://pkg.pr.new/@stackflow/config@560.tgz
yarn add https://pkg.pr.new/@stackflow/link@560.tgz
yarn add https://pkg.pr.new/@stackflow/plugin-history-sync@560.tgz
yarn add https://pkg.pr.new/@stackflow/react@560.tgz

commit: 8ce1fcf

@tonyfromundefined tonyfromundefined changed the title fix(plugin-history-sync): add decode interface to Config and support path: string[] fix(plugin-history-sync): add decode interface to Config and support route: string[] Jan 22, 2025
@tonyfromundefined tonyfromundefined requested review from orionmiz and removed request for ENvironmentSet January 22, 2025 02:37
Copy link
Collaborator

@orionmiz orionmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM)

Suggestion: It might be a good usage to show the decode interface in the demo, which casts articleId to a number. I brought the expected changes. 8ce1fcf How do you think?

@tonyfromundefined
Copy link
Member Author

tonyfromundefined commented Jan 22, 2025

LGTM)

Suggestion: It might be a good usage to show the decode interface in the demo, which casts articleId to a number. I brought the expected changes. 8ce1fcf How do you think?

@orionmiz I think that's a good idea. Could you please push that commit to this branch?

@tonyfromundefined tonyfromundefined merged commit e323ce3 into main Jan 22, 2025
6 of 7 checks passed
@tonyfromundefined tonyfromundefined deleted the history-sync-plugin-decode branch January 22, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants