gplazma: fix banfile plugin #7952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ----------- Issue #7947 reports that banfile only bans user if there is only one 'ban foo:bar' line is present (one line per alias). Further investigation showed that actually only last line is taken. Modification: ------------- Modified BanFilePlugin to use List<String> containing elements already suitable for Pincipal coversion instead of Map<String, String> that naturally only kept the last instance of ban statement. Result: ------- Banfile plugin works as expected. Ticket: #7947 Acked-by: Paul Millar Target: trunk Request: 11.1, 11.0, 10.2 Require-book: no Require-notes: yes
Contributor
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Issue #7947 reports that banfile only bans user if there is only one 'ban foo:bar' line is present (one line per alias). Further investigation showed that actually only last line is taken.
Modification:
Modified BanFilePlugin to use List containing elements already suitable for Pincipal coversion instead of Map<String, String> that naturally only kept the last instance of ban statement.
Result:
Banfile plugin works as expected.
Ticket: #7947
Acked-by: Paul Millar
Target: trunk
Request: 11.1, 11.0, 10.2
Require-book: no
Require-notes: yes