Skip to content

webdav: return 403 on unauthorized attempt to rename resource #7948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 11.1
Choose a base branch
from
Open

webdav: return 403 on unauthorized attempt to rename resource #7948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/dcache-webdav/src/main/java/org/dcache/webdav/DcacheResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import io.milton.http.LockToken;
import io.milton.http.Request;
import io.milton.http.Response;
import io.milton.http.exceptions.BadRequestException;
import io.milton.http.exceptions.ConflictException;
import io.milton.http.exceptions.NotAuthorizedException;
import io.milton.property.PropertySource;
Expand Down Expand Up @@ -115,7 +116,7 @@ public int compareTo(DcacheResource that) {

@Override
public void moveTo(CollectionResource newParent, String name)
throws ConflictException {
throws ConflictException, NotAuthorizedException, BadRequestException {
if (!(newParent instanceof DcacheDirectoryResource)) {
throw new RuntimeException(
"Destination is an unknown type. Must be a DcacheDirectoryResource, is a: "
Expand All @@ -128,8 +129,10 @@ public void moveTo(CollectionResource newParent, String name)
FsPath newPath = directory._path.child(name);
_factory.move(_path, _attributes.getPnfsId(), newPath);
_path = newPath;
} catch (PermissionDeniedCacheException e) {
throw WebDavExceptions.permissionDenied(this);
} catch (CacheException e) {
throw new RuntimeException(e);
throw new WebDavException(e.getMessage(), e, this);
}
}

Expand Down