Handle custom executor Mesos details links

[janisz]

Fixes: MARATHON_UI-144

[janisz]

@Poltergeist Can you tak a look at this?

[Poltergeist]

Thanks @janisz for the contribution. I will have a look at this PR within the next week. Sorry for letting you wait so long.

[Poltergeist]

Hey @janisz, sorry for the delay. I started to get to this Pull request today. The Code looks good so far. And I would like to merge it but unfortunately I don't no how I could test this. It would be great if you could provide a app definition which is using a custom executor.

[janisz]

It's not so easy to test. First of all you need to have a custom executor. For eample it could be sample executor from mesos-go repository https://github.com/mesos/mesos-go/blob/master/api/v1/cmd/example-executor/main.go once you build it you must make it availabe for Mesos to download.

Application definiton will looks like this (I assume executor will be named `executor and will be available at localhost:3000/executor)

{
    "id": "/executor/test",
    "cmd": "env && sleep 300",
    "cpus": 0.1,
    "mem": 32.0,
    "ports": 1,
    "instances": 1,
    "executor": "./executor",
    "fetch": [
        { "uri": "https://localhost:3000/executor" }
    ]
}

[orlandohohmeier]

@Poltergeist did you have a chance to look into this one?

[Poltergeist]

Hey @janisz
I finally achieved the skills necessary to build the example. And I am currently checking out the thing, sorry that this took so long.

Unfortunately the go executor does finish directly. And I was not able to test this PR with a running task. But, and that is the learning along the way, for failing tasks there is not always the executor attribute in the task object. Maybe it is more secure to set the condition onto the executor attribute in the application config?

[janisz]

for failing tasks there is not always the executor attribute in the task object. Maybe it is more secure to set the condition onto the executor attribute in the application config?

@Poltergeist Can you elaborate? Where executor filed is missing? I'll add test case for it but I'm not sure what is missing.

[orlandohohmeier]

@Poltergeist could you please clarify what is not working/missing?

[janisz]

@orlandohohmeier @Poltergeist I think I fixed all issues. Can you check it out?

[janisz]

@orlandohohmeier @Poltergeist We deployed this fix in our infrastructure and it's solved our problems with custom executor and Mesos links.

[orlandohohmeier]

@janisz Pardon for not getting back to you any earlier. @Poltergeist and I will look into your fix today. Thanks again for investing the time to provide and test a fix for MARATHON_UI-144.

[Poltergeist]

@janisz I had a last look at the version everything looks fine. And everything seems to be wired good. Thanks for your patience. I will merge this now.

[janisz]

Cool!

@Poltergeist When will you release new version of Marathon UI. I'd like to update it in Marathon, then release Marathon so we can use official releases instead of custom fork.