Add Dispatchfile #71
Add Dispatchfile #71
Conversation
|
Looks like there's some problems in CI @AliakseiKhomchanka, I've added the other codeowners here let us know if you require any assistance. |
| export GOPRIVATE=github.com/mesosphere/kubeaddons | ||
| ssh-keyscan -t rsa github.com > /etc/ssh/known_hosts | ||
| git config --global url."https://$GITHUB_TOKEN:@github.com/".insteadOf "https://github.com/" | ||
| make kind-test |
There was a problem hiding this comment.
do we want to spin up a kind cluster?
does the underlying node support the creation of kind?
Cannot connect to the Docker daemon at unix:///var/run/docker.sock.
There was a problem hiding this comment.
More recent kind should be playing nicely with podman too, if docker ends up being an issue for some reason? we might have luck there
There was a problem hiding this comment.
It's supposed to be using cluster claim controller to get kubeconfig of a kind cluster that is already running somewhere (from what I understand about cluster claim controller) so I'm not entirely sure why the container needs to be privileged.
|
@AliakseiKhomchanka looks like we're getting close here, need any help from @mesosphere/sig-ksphere-catalog to get this one over the finish line? |
|
@shaneutt The test seems to be broken, Dispatch itself is alright, I think. I'm not a specialist regarding what those tests actually do, anyone that knows? |
I was under the impression that the Perhaps @faiq is a good resource |
|
Please see context from #75 (review) and the JIRA we've created to follow up: https://jira.d2iq.com/browse/D2IQ-71485 Dispatch is now disabled in this repo with the above JIRA being the follow up and this PR is now linked to that JIRA as a PR to re-open once we re-enable it. I'm gonna close this for now so we can prioritize it later as that seems to make sense based on the current context, however if you feel I'm wrong to do so and there's more work to be done immediately in this PR please don't hesitate to re-open this and scold me :) |
|
Everything seems to be working, need a review and can merge. |
|
Squash commits but looking good |
|
This PR has been superseded by #109. |
Adding Dispatch integration for this repo.