Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

use kubeaddons-enterprise-tests repo for tests #68

Merged
merged 4 commits into from
Jul 2, 2020
Merged

use kubeaddons-enterprise-tests repo for tests #68

merged 4 commits into from
Jul 2, 2020

Conversation

zmalik
Copy link
Contributor

@zmalik zmalik commented Jun 15, 2020

re-enabling all tests that now reside in https://github.com/mesosphere/kubeaddons-enterprise-tests

@zmalik zmalik requested a review from nfnt June 15, 2020 13:37
@zmalik zmalik requested a review from a team as a code owner June 15, 2020 13:37
@zmalik zmalik self-assigned this Jun 15, 2020
@zmalik zmalik requested review from kensipe and porridge June 15, 2020 15:25
@zmalik
Copy link
Contributor Author

zmalik commented Jun 17, 2020

soft ping @mesosphere/sig-ksphere-catalog

nfnt
nfnt previously approved these changes Jun 17, 2020
View reviewed changes
@joejulian
Copy link
Contributor

Can we be a little more generic and make that repo a single repo that can be used for kuttl tests for all kubeaddons repos? Maybe just rename it to kubeaddons-tests or something?

This is a great way to solve the problem of legacy installations.

@zmalik
Copy link
Contributor Author

zmalik commented Jun 22, 2020 •
edited
Loading

Can we be a little more generic and make that repo a single repo that can be used for kuttl tests for all kubeaddons > repos? Maybe just rename it to kubeaddons-tests or something?

This is a great way to solve the problem of legacy installations.

@joejulian that's a good idea but as for now that will require more changes in that repo, and its not clear who will maintain those tests. For kubeaddons-enterprise we can help but for all addons it will be hard.

Also other repositories might be tagged or have releases. This is the only repository which master branch is being used as catalog first option, so I wouldn't mind having a dedicated test repository just for this addon repository

faiq
faiq reviewed Jun 23, 2020
View reviewed changes
faiq
faiq reviewed Jun 23, 2020
View reviewed changes
faiq
faiq reviewed Jun 23, 2020
View reviewed changes
faiq
faiq reviewed Jun 23, 2020
View reviewed changes
@zmalik zmalik added the wip label Jun 26, 2020
@zmalik
Copy link
Contributor Author

zmalik commented Jun 26, 2020

I will re-work the PR to include @joejulian suggestion to rename kubeaddons-enterprise-tests to kubeaddons-tests

@zmalik zmalik added ready and removed wip labels Jul 2, 2020
@zmalik
Copy link
Contributor Author

zmalik commented Jul 2, 2020

@joejulian this is ready for review, the test repo has been renamed to kubeaddons-tests and references updated

@shaneutt shaneutt requested review from joejulian and faiq July 2, 2020 11:25
@zmalik zmalik merged commit 2e56fd8 into dev Jul 2, 2020
@zmalik zmalik deleted the zm/add-tests branch July 2, 2020 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nfnt nfnt nfnt approved these changes

@shaneutt shaneutt shaneutt approved these changes

@kensipe kensipe Awaiting requested review from kensipe

@porridge porridge Awaiting requested review from porridge

@joejulian joejulian Awaiting requested review from joejulian

@faiq faiq Awaiting requested review from faiq

Assignees

@zmalik zmalik

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zmalik @joejulian @nfnt @shaneutt @faiq