Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

enable tests again #61

Merged
merged 1 commit into from
May 28, 2020
Merged

enable tests again #61

merged 1 commit into from
May 28, 2020

Conversation

zmalik
Copy link
Contributor

@zmalik zmalik commented May 28, 2020

enabling tests again, which were temporarily removed due to https://jira.d2iq.com/browse/D2IQ-68485

This PR re-introduces tests in different path then addons
I have tested this branch with catalog API to make sure the same issue isn't happening again.

$ (⎈ kubernetes-admin@konvoy-cluster:default) k get addonrepositories.kubeaddons.mesosphere.io -n check-mhdw4-s2d6p kubeaddons-enterprise -o yaml
apiVersion: kubeaddons.mesosphere.io/v1beta1
kind: AddonRepository
metadata:
  creationTimestamp: "2020-05-28T09:55:03Z"
  generation: 2
  name: kubeaddons-enterprise
  namespace: check-mhdw4-s2d6p
  resourceVersion: "44130"
  selfLink: /apis/kubeaddons.mesosphere.io/v1beta1/namespaces/check-mhdw4-s2d6p/addonrepositories/kubeaddons-enterprise
  uid: da8db76e-e02f-42c8-a8c7-c81ced8f648b
spec:
  options:
    credentialsRef: {}
  priority: "1"
  ref: zm/enable-tests
  url: https://github.com/mesosphere/kubeaddons-enterprise
status:
  ready: true

~/repos/clusters/konvoy-cluster ⌚ 11:59:34
$ (⎈ kubernetes-admin@konvoy-cluster:default) k logs kommander-kubeaddons-kubeaddons-catalog-6654f856df-c5jt7 -n kommander
2020/05/28 09:56:55 starting app in environment production
level=info time="2020-05-28T09:56:55Z" msg="Starting application at http://0.0.0.0:3000"
level=info time="2020-05-28T09:56:55Z" msg="Starting Simple Background Worker"
2020-05-28T09:56:57.068Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":9094"}
2020-05-28T09:56:57.068Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2020-05-28T09:56:57.069Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "addonrepository", "source": "kind source: /, Kind="}
2020-05-28T09:56:57.187Z	INFO	controller-runtime.controller	Starting Controller	{"controller": "addonrepository"}
2020-05-28T09:56:57.187Z	INFO	controller-runtime.controller	Starting workers	{"controller": "addonrepository", "worker count": 1}
2020-05-28T09:56:57.187Z	INFO	addonrepository-controller	Retrieving namespace	{"addonRepository": "check-mhdw4-s2d6p/kubeaddons-enterprise"}
2020-05-28T09:56:57.288Z	INFO	addonrepository-controller	Retrieving addonRepository	{"addonRepository": "check-mhdw4-s2d6p/kubeaddons-enterprise"}
2020-05-28T09:56:57.728Z	INFO	addonrepository-controller	AddonRepository has been added, no status change - nothing to do here	{"addonRepository": "check-mhdw4-s2d6p/kubeaddons-enterprise", "addonRepository": "kubeaddons-enterprise"}
2020-05-28T09:56:57.729Z	DEBUG	controller-runtime.controller	Successfully Reconciled	{"controller": "addonrepository", "request": "check-mhdw4-s2d6p/kubeaddons-enterprise"}
2020-05-28T09:56:57.787Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"AddonRepository","namespace":"check-mhdw4-s2d6p","name":"kubeaddons-enterprise","uid":"da8db76e-e02f-42c8-a8c7-c81ced8f648b","apiVersion":"kubeaddons.mesosphere.io/v1beta1","resourceVersion":"44130"}, "reason": "Success", "message": "Repository \"kubeaddons-enterprise\" has been added"}
level=info time="2020-05-28T09:57:12Z" msg="/v1beta1/namespaces/check-mhdw4-s2d6p/repositories/?per_page=all" content_type=application/json duration="121.538µs" human_size="177 B" method=GET params="{\"namespace\":[\"check-mhdw4-s2d6p\"],\"per_page\":[\"all\"]}" path="/v1beta1/namespaces/check-mhdw4-s2d6p/repositories/?per_page=all" render="93.95µs" request_id=59702f6c899b1536a5f1-f2b4524043b14b701fbf size=177 status=200

@zmalik zmalik requested review from joejulian and nfnt May 28, 2020 10:02
@zmalik zmalik requested a review from a team as a code owner May 28, 2020 10:02
@zmalik zmalik self-assigned this May 28, 2020
Copy link
Contributor

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zmalik zmalik merged commit 44619f9 into master May 28, 2020
@zmalik zmalik deleted the zm/enable-tests branch May 28, 2020 12:53
@jieyu
Copy link
Contributor

jieyu commented May 28, 2020

Reverted this PR again, we hit a similar issue again after this change
https://mesosphere.slack.com/archives/CLETZF5U6/p1590691584239700

The cluster is using: mesosphere/kubeaddons-catalog:v0.8.3

jieyu added a commit that referenced this pull request May 28, 2020
@jieyu jieyu mentioned this pull request May 28, 2020
jieyu added a commit that referenced this pull request May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants