This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fix Spark 2.4.5 params.yml reference #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeygorobets
previously approved these changes
Apr 6, 2021
alembiewski
reviewed
Apr 6, 2021
There was a problem hiding this comment.
I see the parameters file version doesn't match with the version of the operator:
https://github.com/mesosphere/kubeaddons-enterprise/blob/907b5c9406b11d400b4706c36ff189cd100e5826/addons/spark/1.x/spark-2.yaml#L35
Should we specify 1.0.1 here as well?
|
@alembiewski fixed, thanks for spotting that! |
kaiwalyajoshi
added a commit
that referenced
this pull request
Apr 9, 2021
* fix small nits (#81) * fix: use correct CODEOWNERS syntax We want to assign owners to `/addons/ADDON/` and any of its sub-directories so it has to be `/addons/ADDON/` and not `addons/ADDON/*` because the latter only catches files directly in the `ADDON` dir but not in any of its sub-dirs. * Add repo for jenkins chart (#98) * Provide details on how to manually test staging addons (#93) * Update CODEOWNERS (#101) * Update addons for KUDO's Kafka 2.5.1-1.3.3, Cassandra 3.11.7-1.0.2 (#91) * Update addons for KUDO's Kafka 2.5.1-1.3.3, Cassandra 3.11.7-1.0.2 * Enable missing cloudProviders for kafka and cassandra Co-authored-by: Dominik Dary <DominikDary@users.noreply.github.com> Co-authored-by: Rishabh Bohra <rishabhbohra01@gmail.com> * chore: Update Jenkins version to fix merge conflict (#105) * Update Jenkins version to fix merge conflict * Address review comments * Dispatch file integration (#109) * parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426577 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hm1EACgkQBhrghUGj V0nXJgv/Sy9bRkttFNupBH8o4lr4xKi+I2MbnQGxAHwYoYxDyEewx9Yj75oeb34Q Xz5juP5piq2ZfcQYrZ1rAqRfPC6ouZvdB6XaZm3rVd3farZCIjpnXTqy3WZl92fR upa2KGPcziojgIsLKiqIhewXKMt1vhXjHSLCQ1CxEtr4vltRAJ5ui2TGLW1OS8DZ H3sEcAOV9z4JjgQOIufkVpWMANn2GT0gxtgOUtyr20xiw+ygIPOGXfrE4Dgr35d7 ENlEpwSJTCQgypQJm2JeXWrKtaxib6cOFdw/aS+6PPFcnBaO4ZbuTbja00eJ5yac kZ23AMit1HOHiB5fa4NkitmuvJMLSeiCncjjEuLwrEP/IWaFSpWPRnqzI5owlbMx echtz1EJX7NpruLGWotb1Jo2pJDEdP18/LyjhYJXocCqBa/crMpjCGt14Gh8phpb 9WRGUyq2/pc9C7HuVtjJwVwajj6RV9W30lkqLpJk3bF98q8zBlVvEpZtNTiiAnWz lgsAN8bE =zBwV -----END PGP SIGNATURE----- parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426543 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hmy8ACgkQBhrghUGj V0kH0gwAm0ObPYGRl2S1J7QQi9bj2jiFPb0eP2Oia9anX/seiX0MP3vyY+udyHYy pU2rClUtTU5eQ8NN0DrT1wuxRjaq3gkohxXpiLG4tzW1pmJNchwP10Af/zZ/DUr3 ANIjrkAyyr3MHmZKcmdDNiU8wfNvNgw8ACMGaKgyMtE5zmfhU9i36zp/hqnEs5gr njR+Kw3H9jkBhBm/FnSqRaju14EFdceAGK3Bc8gflPAZGhRqg48LR+UfVngTDf8D apnlm8IhgrpqvLcuUp97Px0CXVeYDsCr1k3xSxE6BMz9mvfmN75MW+pRpC5b7vIO 0Q8f7ur6Bl0yDATUsNoRJHrAt65tsOGOxau3oeZjnSoP44JRszfxVzKD4IAm8hUy 1a1AnPIONNAk0sAJNeco4BwcgsEfCkOn87IZXxs9RXfam9K4oDd1KPqK1OcFk1h9 Zi3hf6tY4lc7x2AmNj2iJOHk25DfD0g/O6VYRGBVp24RxKgTFTh/xifqE/XygdYA +/Cv+L8U =0Xm8 -----END PGP SIGNATURE----- parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426525 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hmx0ACgkQBhrghUGj V0lWbQv/e8D0Is82OeAXS1G8xbSbRuKiRovZ9ujkTgiJnTS5xC5sKpW+vsmmOoij Fu/VnwLPhltmUNaHFs05zGQsHkceuZp6HIuhZwl6b19itGCIsRt86r0TuNg0HIKv SyK64uJ4oJQGqEs9cWwy3IBJtIGSRkal4UDq3qc8NejuY9sDZv5LR4Vj1yAyGssI 9O/kLkuHr4uT18lXKLgolqzuDK5SAkFAIKM1hcHPjEQbB9xCaDGg2Sma+Lh76qI7 omvI+8zvGo2hQ0daa1Q+goqKRojZsvepATSKucxPyGiQGU1xTAlCUQ/Ee4HlbGwt /24Ggkg3ta+vRKNnxmoLSwGsl7XN/taLSwL77NxaVRArvWdJRpwmwMlqOl+LgSjj fxF9XVLOnRMQQDH/h7YHVw3fokhPuczQ3Cepq5Oq91kBDUXLK7m8o/s2944i4Hhl gdTBndxFW969+RK/AYCENHfhL2XBjVc7QfvJKQ7TY2/TR30my2VJCA8bWDHoiF3j kAQF6x3f =XLOr -----END PGP SIGNATURE----- parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426476 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hmuwACgkQBhrghUGj V0kw2QwAgzEWQ1SUnaxokiVa9srJ2Yp1gKJ5/KedOBXk9ym+0aCiUydYLX1WnTdy 9Y01JSWPZd/DhPc6AygW1NbkCbATq+OyoSBuHNhvxOOok4gdwdevAdAP8yoLxC5U eNub16QIB4qbtxnbiAvoHC03tTDzutEjwLHN2HT5ySuZiMHf1mHdr/L4PD89nh0M CMhjjLEgqfQhpFfZJpBrAbEIhN7Naz6AEha9n4LLhI956ll5gnG2vIp+gfcwcB0w H3biev6oj/Mm6Onxir1JlGibOzRl8hRpXUGwD+BBcPrZWFMcAIULqnHgHP5Hue/d /9SxC1Vd58fGoUAq9wepX4bIYRNJkEg9oX18c4WsW2xhfSBsFU/iTJ/rP0dnTHp0 EJxqbziLK+9g8/WxE1KB20n/5TGWWszjzIAUrYnY5AqXeyJTycZpoJYAoncDWqgd wstj+tuiysRb1Frw2Pj3KjgOQKFoGRCP2LqzVquO2pA2nXp98xJum6YdYpuFa8gF +LzAlLm4 =XfMK -----END PGP SIGNATURE----- parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426148 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hmaQACgkQBhrghUGj V0mz1gv/Q6Z10U6D2d6QL+8ReCazvOuZCL3GxGp2UGqrIHyu1q1IfLN9GVrzoxwc q288/+ACuDtdSvOaIKpXYFUN/SYAghop1dUlO2zIP/4anEUUG/H6/5Y6Dc2bGWKz h0bh6PSRNn8/qnMhX/cZkHk+vJ6Dt19w1nlC3ZMAG5oADgU4WcQFbeYt43tpeqT3 w6ua+PPaQ2Um3Dr5RfMqzHKQEbSL3o0r9IRNULilYgQee5TKI5h7E1JSMDUIOeH1 UIOQAg6nCDAJ7x77VBdXlZz04Bkmfnww+wzRuAn+oYes+01/9Mxj0usMLboaRyY/ dQDUuPG04nx8Br8mtSmg7+Gm7P4Rxlw8ZAC+ATyuiCCtvP31mjR+dIol//pzLvlL VQLKlLmnJf2ERUCXOuZqFxMZV8EiVoFXx7W3sWlEWDDSA0PhVcqv3B+/FoYrujgP 9A92/gA3mExVSLpJDqfZ7RwZ6+9tdy/YnuaKjZ+FJ/Pd7t0aRRsgALZwqh8TSbM0 hpmr6qiX =SnLl -----END PGP SIGNATURE----- parent 43b9984 author Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> 1596125967 +0200 committer Alex <khomchankaa@gmail.com> 1604426029 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEupf8HVi8W3w4JZ7xBhrghUGjV0kFAl+hmS0ACgkQBhrghUGj V0kmFgwAptm2L4KI1eU6fwxHtyvHbPMXNReQiHvng87zI8txv7Z+G2y8fV56vHZ7 sqnjib/G3YsV7QyqmA5/tG4nCv9kOwBc4ds2jwNrBs5MbISVv3s0qxbsAvshWhW7 ld7J4sUsoBo3jQIE5lknktFOFhFZ6fVKzn3P+fqBinkFBMVmZfGhxZaZPQK94cih espqGag4jQJC4fjKMBVlSspz1z6thsg9xBSi6u2wte7jR2Ha0tBifMFdoqHzW3cR fRjdR6Yr4dJvENT3Jb9kjotjrdwDAaBxO8tlx0sYJxiUfNmb/MakNqaqgWz+EYd/ 72JKc/8FPswFQ3FbCiwbJvlSdCd2A3vEkZ7PsZx/NF+tvm8qKSfVADmbsOtthX/b ff9skvvWLKx4BeNf5CmwLjhftTwWw4RJ1Z6acPmlanMB6GscA4HstEqFDUrUnU2W dpKoZgse4WJaBbIQnijfw9LZar5Gr++aNC3+W8ZSp8WBFdSBeRXCo+QxPhPwYmJ6 Xctv8cOB =cT1q -----END PGP SIGNATURE----- Add Dispatch integration to kubeaddons-enterprise * Remove dindTask from imports * Update Makefile * Update Makefile * Change make target * Update Dispatchfile * Update Dispatchfile * Update Dispatchfile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Makefile * Update Dispatchfile * Update Makefile * Update Makefile * test * Make properly * Make * Remove dispatch test make target * Fix clean target as well * Adds comments from review Co-authored-by: Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> Co-authored-by: Rishabh Bohra <rishabhbohra01@gmail.com> * Fixes the params link in Cassandra to refer correct versions (#110) * Add Kudo Spark 3.0.0-1.1.0 (#113) * Add Kudo Spark 3.0.0-1.1.0 * change min supported k8s version to v1.16.0 * set release commit instead of master for kudo params Co-authored-by: Aleksei Gorobets <agorobets@d2iq.com> * chore: Bump KUTTL to 0.8.0 (#116) * Add Elasticsearch & Kibana 7.10.0 (#119) * Add Certification Label for Kommander Catalog Services. (#126) * Add certification annotation. * Add certification levels to each of the existing Platform Services. * Make certifications machine-readable. (#128) * Make certifications machine-readable. * Use Stringified JSON. * Fix Spark 2.4.5 params.yml reference (#130) * Fix Spark 2.4.5 KUDO params.yml file to use values from Spark Operator 1.0.1 Release kudobuilder/operators@d4cbfc3 * Update operator version to 1.0.1 Co-authored-by: Zain Malik <zmalikshxil@gmail.com> Co-authored-by: Max Jonas Werner <mwerner@d2iq.com> Co-authored-by: Rishabh Bohra <rishabhbohra01@gmail.com> Co-authored-by: Jan Schlicht <jan.schlicht+gh@gmail.com> Co-authored-by: Dominik Dary <DominikDary@users.noreply.github.com> Co-authored-by: Faiq Raza <faiq@users.noreply.github.com> Co-authored-by: Alex <37959197+AliakseiKhomchanka@users.noreply.github.com> Co-authored-by: Farhan <farhan5900@gmail.com> Co-authored-by: Alexey Gorobets <alexey.gorobets.v@gmail.com> Co-authored-by: Aleksei Gorobets <agorobets@d2iq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Spark 2.4.5 to use the params.yml file associated with Spark Operator 1.0.1 Release