Improve the completion tests a bit (apple#228)

d1248966459 · Aug 12, 2020 · b905f5c · b905f5c
1 parent 6180c8b
commit b905f5c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 10 deletions.
diff --git a/Tests/ArgumentParserExampleTests/MathExampleTests.swift b/Tests/ArgumentParserExampleTests/MathExampleTests.swift
@@ -185,6 +185,31 @@ extension MathExampleTests {
       command: "math --generate-completion-script zsh",
       expected: zshCompletionScriptText)
   }
+
+  func testMath_CustomCompletion() {
+    AssertExecuteCommand(
+      command: "math ---completion stats quantiles -- --custom",
+      expected: """
+        hello
+        helicopter
+        heliotrope
+        """)
+
+    AssertExecuteCommand(
+      command: "math ---completion stats quantiles -- --custom h",
+      expected: """
+        hello
+        helicopter
+        heliotrope
+        """)
+
+    AssertExecuteCommand(
+      command: "math ---completion stats quantiles -- --custom a",
+      expected: """
+        aardvark
+        aaaaalbert
+        """)
+  }
 }
 
 private let bashCompletionScriptText = """

diff --git a/Tests/ArgumentParserUnitTests/CompletionScriptTests.swift b/Tests/ArgumentParserUnitTests/CompletionScriptTests.swift
@@ -116,16 +116,7 @@ extension CompletionScriptTests {
   }
 
   func testEscaped_Zsh() throws {
-    let script1 = try CompletionsGenerator(command: Escaped.self, shell: .zsh)
-          .generateCompletionScript()
-    XCTAssertEqual(zshEscapedCompletion, script1)
-
-    let script2 = try CompletionsGenerator(command: Escaped.self, shellName: "zsh")
-          .generateCompletionScript()
-    XCTAssertEqual(zshEscapedCompletion, script2)
-
-    let script3 = Escaped.completionScript(for: .zsh)
-    XCTAssertEqual(zshEscapedCompletion, script3)
+    XCTAssertEqual(zshEscapedCompletion, Escaped.completionScript(for: .zsh))
   }
 }