Skip to content

fix: start from current STH/checkpoint when no saved index exists #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnana997 wants to merge 1 commit into
base: static-ct
Choose a base branch
from
Open

fix: start from current STH/checkpoint when no saved index exists #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions internal/certificatetransparency/ct-watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,10 @@ func (w *worker) runStandardWorker(ctx context.Context) error {
return errCreatingClient
}

// If recovery is enabled, we start at the saved index. Otherwise, we start at the latest STH.
recoveryEnabled := config.AppConfig.General.Recovery.Enabled
if !recoveryEnabled {
// If recovery is enabled AND we have a saved index > 0, use it.
// Otherwise, fetch the current STH and start from there.
hasSavedIndex := config.AppConfig.General.Recovery.Enabled && w.ctIndex > 0
if !hasSavedIndex {
sth, getSTHerr := jsonClient.GetSTH(ctx)
if getSTHerr != nil {
// TODO this can happen due to a 429 error. We should retry the request
Expand Down Expand Up @@ -416,9 +417,10 @@ func (w *worker) runStandardWorker(ctx context.Context) error {
func (w *worker) runTiledWorker(ctx context.Context) error {
hc := &http.Client{Timeout: 30 * time.Second}

// If recovery is enabled and the CT index is set, we start at the saved index. Otherwise we start at the latest checkpoint.
validSavedCTIndexExists := config.AppConfig.General.Recovery.Enabled && w.ctIndex >= 0
if !validSavedCTIndexExists {
// If recovery is enabled AND we have a saved index > 0, use it.
// Otherwise, fetch the current checkpoint and start from there.
hasSavedIndex := config.AppConfig.General.Recovery.Enabled && w.ctIndex > 0
if !hasSavedIndex {
checkpoint, err := FetchCheckpoint(ctx, hc, w.ctURL)
if err != nil {
log.Printf("Could not get checkpoint for '%s': %s\n", w.ctURL, err)
Expand Down