Add support for Websocket compression #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to enable compression for websockets. The compression is disabled by default due to the fact that it is marked as experimental in gorilla/websocket and there have been issues with compression whenever Safari is enabled. This commit partially addresses d-Rickyy-b#30.
alberts-s
force-pushed
the
add-compression
branch
from
be9b0f4
to
9e6c5de
Compare
I appreciate the comment as explanation, but using regular bools in the struct will lead to the default values being parsed. The default value for bools is "false". So there's no need to use a pointer in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to enable compression for websockets. The compression is disabled by default due to the fact that it is marked as experimental in
gorilla/websocketand there have been issues with compression whenever Safari is enabled.This PR partially addresses #30.