-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add share button to bottom sheet #22
Comments
Base implementation. Contact and other specific implementations yet to be added.
can we add a share button in the bottom dialog and pass the text fields to that and share them using intent. |
We can add a chip to the current Actions pane. Currently, I have a Share Action ready, but the implementation is not quite polished:
It calls data.constructShareIntent for the data type. https://github.com/czlucius/code-scanner/blob/main/app/src/main/java/com/czlucius/scan/objects/actions/ShareAction.java#L42 So for the data types in https://github.com/czlucius/code-scanner/tree/main/app/src/main/java/com/czlucius/scan/objects/data, you have to override the |
so we have to create intents for special cases and override the custom intent. |
Yes |
For contacts you have to create a VCF file and share via the content provider |
An example |
Hello @czlucius can you assign this project to me so that I will try to add share button at bottom sheet. |
You can come out with the code changes first, and make a PR. Afterwards, I will assign the issue. |
barcode library from android is deprecated. and it is giving some error in my studio. |
Can I have a screenshot? ML Kit is not deprecated, its still supported by Google. |
I am still figuring it out. Will contact you if doesn't find anything. |
Is your feature request related to a problem? Please describe.
Users cannot share the scanned text and have to copy and paste in their desired app
Describe the solution you'd like
Add a share chip to the action bar on the bottom sheet dialog.
Describe alternatives you've considered
Copy and paste the text scanned.
Additional context
The text was updated successfully, but these errors were encountered: