Fixes

cziter15 · Dec 20, 2023 · db60f5d · db60f5d
1 parent 8ec71a3
commit db60f5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/firmware/src/apps/raesp/comps/RadioCommander.cpp b/firmware/src/apps/raesp/comps/RadioCommander.cpp
@@ -85,12 +85,10 @@ namespace apps::raesp::comps
 			Topics like OOK/1234/16 will be handled by nexa protocol.
 			Topics like OOK/1 will be handled by ningbo protocol.
 		*/
-		auto delim_idx{topic.find('/', rfTopicPrefix.length() + 1)};
-
 		uint32_t address{0};
 		int16_t unit{RC_UNIT_NONE};
 
-		if (delim_idx != std::string_view::npos)
+		if (auto delim_idx{topic.find('/', rfTopicPrefix.length() + 1)}; delim_idx != std::string_view::npos)
 		{
 			auto address_sv{topic.substr(rfTopicPrefix.length(), delim_idx - rfTopicPrefix.length())};
 			if (!ksf::from_chars(address_sv, address))

diff --git a/firmware/src/apps/raesp/protocols/ningbo.cpp b/firmware/src/apps/raesp/protocols/ningbo.cpp
@@ -20,8 +20,8 @@ namespace apps::raesp::protocols
 {
 	void tx_ningbo_bit(const proto_pins& pins, const char bitChar)
 	{
-		bool isBitCharOne = bitChar == '1';
-		if (bitChar == '0' || isBitCharOne)
+
+		if (bool isBitCharOne{bitChar == '1'}; bitChar == '0' || isBitCharOne)
 		{
 			proto_high_for(pins,PULSE_SHORT_A);
 			proto_low_for(pins, PULSE_LONG_B);