Skip to content

Commit

Permalink
fix: alert messages too wide in dialogs
Browse files Browse the repository at this point in the history
  • Loading branch information
czabaj committed Sep 12, 2024
1 parent 992b250 commit abf3a5e
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 16 deletions.
4 changes: 0 additions & 4 deletions src/pages/PlaceSetting/KegDetail.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@
.dialogCloseKeg p:first-of-type {
font-size: 90%;
}
.dialogCloseKeg p:last-of-type {
margin-inline: var(--dialog-padding-inline);
padding-inline: 2rem;
}
4 changes: 2 additions & 2 deletions src/pages/PlaceSetting/KegDetail.res
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,10 @@ let make = (
efektivita výtoče.`)}
</p>
{effectivity > 0.7
? <p className=Styles.messageBar.base>
? <p className=Styles.messageBar.base role="alert">
{React.string(`Rozúčtování je nevratná operace. Ujistěte se, že máte správny sud.`)}
</p>
: <p className={`${Styles.messageBar.base} ${Styles.messageBar.variantDanger}`}>
: <p className={Styles.messageBar.variantDanger} role="alert">
<b> {React.string(`Efektivita výtoče je velmi nízká.`)} </b>
{React.string(` Rozúčtování je nevratná operace. Ujistěte se, že máte správny sud.`)}
</p>}
Expand Down
10 changes: 4 additions & 6 deletions src/pages/PlaceSetting/PlaceDelete.res
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ type classesType = {root: string}

@module("./PlaceDelete.module.css") external classes: classesType = "default"


module FormFields = {
type state = {name: string}
type rec field<_> = Name: field<string>
Expand Down Expand Up @@ -47,11 +46,10 @@ let make = (~onConfirm, ~onDismiss, ~placeName) => {
onDismiss={onDismiss}
visible=true>
<Form.Provider value=Some(form)>
<p>
{React.string(`Pokud si přejete smazat místo, napište jeho název a potvrďte. `)}
<strong>
{React.string(`Smazání místa je nevratná operace, tímto ztratíte veškeré údaje o místu a nepůjdou vrátit zpět!`)}
</strong>
<p> {React.string(`Pokud si přejete smazat místo, napište jeho název a potvrďte. `)} </p>
<p className={Styles.messageBar.variantDanger} role="alert">
<strong> {React.string(`Smazání místa je nevratná operace!`)} </strong>
{React.string(` Tímto ztratíte veškeré údaje o místu a nepůjdou vrátit zpět`)}
</p>
<form id="place_delete" onSubmit={ReForm__Helpers.handleSubmit(form.submit)}>
<fieldset className={`reset ${Styles.fieldset.grid}`}>
Expand Down
6 changes: 6 additions & 0 deletions src/styles/components/messageBar.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,9 @@
.variantDanger::before {
content: "🚨 ";
}

dialog .base {
margin-inline: var(--dialog-padding-inline);
padding-inline-end: 0.75rem;
padding-inline-start: calc(0.5rem + 3ch);
}
5 changes: 1 addition & 4 deletions src/styles/reset.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ dialog:modal {
color: var(--text-2);
}

dl,
dl dd,
p,
[popover] {
:where(dl, dl dd, p, [popover]) {
margin: 0;
padding: 0;
border: 0;
Expand Down

0 comments on commit abf3a5e

Please sign in to comment.