-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ipython to rtd requirments file #309
Conversation
@axiomcura I am currently working on migrating the pycytominer dependency management to poetry. I don't think this change will be something that will impact what I'm working on, but it would be really helpful if you could provide additional context about this change and why it's needed. |
Hello @kenibrewer! of course The main issue was the After some digging, I found that including the I hope this provides more clarity. If you have any further questions or need additional assistance, please feel free to ask! |
Hello, this is a courtesy notice that Pcytominer's |
@d33bs - can you review my recent commit when you get a chance? Our RTD build was failing https://readthedocs.org/projects/pycytominer/builds/21654686/ after the move to poetry. I tried to fix |
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 56 56
Lines 3134 3134
=======================================
Hits 2990 2990
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the suggestions @d33bs and @kenibrewer ! It looks like the tests now pass. Can either of you provide a 👍 and then I will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work! I tested the docs build here and everything seemed to work okay: https://readthedocs.org/projects/pycytominer-test-docs/builds/21928119/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. I'll create a separate issue for potentially migrating the rest of the docs/requirements.txt dependencies into pyproject.toml sometime in the future.
Thanks both! (and thanks to @axiomcura for initially opening this!) Merging now |
modified from EmbeddedArtistry
Description
Thank you for your contribution to pycytominer!
Please succinctly summarize your proposed change.
What motivated you to make this change?
Please also link to any relevant issues that your code is associated with.
What is the nature of your change?
This PR focuses on fixing the syntax highlighting not able to be rendered in the
pycytominer
'swalkthrough
webpage.Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.