Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear_method_caches to Utils.py #4338

Merged
merged 8 commits into from
Oct 28, 2021

Conversation

0dminnimda
Copy link
Contributor

This PR adds functionality used in #4241

@0dminnimda
Copy link
Contributor Author

(ubuntu-18.04, 2.7, cpp, 1, -all) (pull_request) Cancelled after 30m

hmm, let's try to restart ci ..

But it seems that 2.7 -all runs take quite a long time, maybe we will have to increase the maximum time

@0dminnimda 0dminnimda closed this Aug 12, 2021
@0dminnimda 0dminnimda reopened this Aug 12, 2021
0dminnimda added a commit to 0dminnimda/cython that referenced this pull request Aug 12, 2021
0dminnimda added a commit to 0dminnimda/cython that referenced this pull request Aug 12, 2021
Cython/Utils.py Outdated Show resolved Hide resolved
@0dminnimda
Copy link
Contributor Author

@scoder could you please review this PR?

@0dminnimda
Copy link
Contributor Author

@scoder I'd like you to take a look at this.

Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor suggestion below.

Cython/Utils.py Outdated Show resolved Hide resolved
@scoder scoder added this to the 3.0 milestone Oct 22, 2021
@scoder scoder added the cleanup label Oct 22, 2021
@0dminnimda
Copy link
Contributor Author

@scoder now it seems that we are ready to merge

@scoder scoder merged commit cfb8879 into cython:master Oct 28, 2021
@0dminnimda 0dminnimda deleted the add-clear_method_caches-to-Utils.py branch February 25, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants