Enhance Engine Class Readability and Maintainability #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaskleiven
changed the title
|
I had a look over, it looks good. Is this ready to merge? Or you are still working on it (marked as draft)? |
cyrusbehr
reviewed
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
I've made an attempt on improving the readability and maintainability of the
Engineclass. This PR includes a refactor, with an option to split the logic into smaller files. The refactoring only involves lifting and shifting inline functions into.inland.hfiles; no logic or functionality has been changed.If the current structure works better for you, feel free to dismiss this PR.