Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include user option #963

Closed
wants to merge 1 commit into from

Conversation

thampton
Copy link

@thampton thampton commented Jul 14, 2023

Update README.md documentation to address #618

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator

@thampton

The example in the README > Docker image works correctly with or without specifying options: --user 1001. Normally the user 1001 is only necessary for Firefox, however I understand that you have had a different experience.

There are already open PRs

to deal with the Firefox issue. These are waiting for feedback from the Cypress team at the moment.

If we are missing some other case then it would be good to understand this before making documentation changes. Please also make yourself familiar with the CONTRIBUTING.md document as you haven't used semantic commit conventions. It's also better not to make changes in a fork's master branch as it makes reviewing more difficult. You don't need to change the branch this time, but any new PR you submit should use a different name.

@nagash77 nagash77 self-assigned this Jul 24, 2023
@MikeMcC399
Copy link
Collaborator

@thampton

@MikeMcC399
Copy link
Collaborator

@thampton

I have picked up your suggestion from this PR and incorporated it in a new PR #992.

@MikeMcC399
Copy link
Collaborator

@nagash77 nagash77 closed this Aug 16, 2023
@nagash77 nagash77 removed their assignment Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants