test: remove comment about rebuilding dist in node test #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the following comment from .github/workflows/example-node-versions.yml:
"# Hmm, should we rebuild the "dist" before using the action?"
It's unclear whether this was supposed to be an exercise for the reader or a to-do task for the author of the comment!
In fact it is not necessary to rebuild the
dist/
folder because:the workflow .github/workflows/check-dist.yml independently rebuilds and checks the consistency of the
dist/
folderin practice the result of rebuilding the
dist/
folder under the currently supported Node.js 16, 18 and 20 versions is identical anyway, with: