Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove comment about rebuilding dist in node test #960

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jul 12, 2023

This PR removes the following comment from .github/workflows/example-node-versions.yml:

"# Hmm, should we rebuild the "dist" before using the action?"

It's unclear whether this was supposed to be an exercise for the reader or a to-do task for the author of the comment!

In fact it is not necessary to rebuild the dist/ folder because:

  1. the workflow .github/workflows/check-dist.yml independently rebuilds and checks the consistency of the dist/ folder

  2. in practice the result of rebuilding the dist/ folder under the currently supported Node.js 16, 18 and 20 versions is identical anyway, with:

    npm run format
    npm run build
    git status

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 12, 2023 14:49
@nagash77 nagash77 merged commit aeaeb91 into cypress-io:master Jul 12, 2023
114 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/node-test-comment branch July 12, 2023 17:59
@github-actions
Copy link

🎉 This PR is included in version 5.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants