Skip to content

Conversation

@piotrekkr
Copy link
Contributor

No description provided.

@piotrekkr
Copy link
Contributor Author

@mjhenkes Can you have a look? I just cloned master and run npm run build

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

@mellis481
Copy link

As mentioned here, I still see set-output and save-state refs in dist/index.js which I wouldn't expect to see if this PR, in fact, addresses the deprecated usage of those two commands. I also would advise testing with a beta release to ensure this is working as expected.

We need a maintainer to address both of the items I mentioned above.

CC: @jaffrepaul @mjhenkes @bahmutov

@piotrekkr
Copy link
Contributor Author

@mellis481 I tried running action as piotrekkr/github-action@update-dist-files and I did not get any warnings from GitHub any more.

@lwhiteley
Copy link

@mellis481 looking deeper at the code the set-output just seems to be a name of the command being issued.
The actual action being done is not the old one as the library has been updated

@jaffrepaul
Copy link
Contributor

jaffrepaul commented Nov 23, 2022

piotrekkr

Thank you everyone for your contributions here and in the other thread(s).

I'm going to get a closer look at this immediately following the holiday. I'd rather not kick off a new build right before most people will be afk.

In the interim @piotrekkr please sign the CLA agreement above so that I'll be able to merge this PR. The commit message subject can also be formatted per semantic commit convention so that a build will trigger.

Also, this repo needs some attention to address some failing tests (unrelated to this work) and outdated deps. This is likely to be included in an initiative moving forward to keep Cypress tools better maintained. Contributions are always welcome.

@piotrekkr piotrekkr changed the title rebuild dist files fix: rebuild dist files Nov 24, 2022
@piotrekkr
Copy link
Contributor Author

@jaffrepaul I signed CLA and also updated and force pushed commit message. Is it okay now?

Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the deprecation message is now gone in a test build.

Merging this to trigger a new release 🎉

@jaffrepaul jaffrepaul merged commit d79d2d5 into cypress-io:master Nov 28, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants