Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rework example-basic #1263

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Sep 18, 2024

Change

The workflow .github/workflows/example-basic.yml is refactored as follows:

  • The workflow is converted to use a matrix of operating systems for clarity
  • ubuntu-24.04 is added
  • latest operating systems are pinned to concrete versions for stability:
    • windows-latest changed to windows-2022 (Windows Server 2022)
    • macos-latest changed to macos-14 (macOS 14 Arm64)

@MikeMcC399 MikeMcC399 added type: enhancement New feature or request tests labels Sep 18, 2024
@MikeMcC399 MikeMcC399 self-assigned this Sep 18, 2024
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review September 18, 2024 12:50
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Sep 25, 2024

@jennifer-shehane

PR from September requesting review and merge!

Blog announcement from GitHub https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/ dated Sep 25, 2024.

@MikeMcC399 MikeMcC399 changed the title ci: refactor example-basic ci: rework example-basic Sep 30, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one!

@jennifer-shehane jennifer-shehane merged commit 2bccd4a into cypress-io:master Oct 2, 2024
74 checks passed
@MikeMcC399 MikeMcC399 deleted the refactor/example-basic branch October 2, 2024 14:45
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Sorry I missed this one!

Thank you for merging! Now this repo is using ubuntu-24.04 as default (this is now also labeled ubuntu-latest).

At some stage I would expect ubuntu-20.04 to be deprecated and withdrawn, as GitHub's policy is to support only 2 versions of each OS (see GA). That would be the trigger to remove the use of Ubuntu 20.04 in this GitHub Actions repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants