-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge action breaking for me #135
Comments
Does you setup work if you switch the browser to Chrome or switch the 'runs-on' to another OS? Just want to make sure we exclude it being a problem with the rest of the action. |
I tried switching "edge" for "chrome" and got the same results: name: E2E Tests (Edge Chromium)
on: [push]
jobs:
cypress-run-Edge:
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v2.1.0
- name: Cypress run
uses: cypress-io/github-action@v1.16.1
with:
browser: chrome
build: yarn build
start: yarn start:test
wait-on: http://localhost:3000
As for switching OS, are you aware of which other options should support edge? AFAIK, only |
I have the FF and Chrome runners set up running on ubuntu just fine if that's what you mean. |
My tests were running well in windows-latest edge, but once that problem came out, when re-executing the workflows it worked again. Update: |
@jennifer-shehane I think this is due to cypress-io/github-action is using a forked version of action/cache. On the main line, there's a patch that seems to fix the issue: https://github.com/actions/cache/pull/126/files If cypress-io/github-action-cache cherrypicks this commit it should be fine. |
Could you please use the latest v2 version of this action? We have switched to the official cache module, thus this problem should be solved. |
This is an old issue and I'm just looking at Edge right now. The example-edge test on Is there any outstanding issue with Edge or can this be closed? |
Could this be related with #620 ? |
|
@MikeMcC399 sorry I missed your comment but you are correct this issue should be closed at this point as resolved. If folks are still seeing issues using edge please open a new issue with a reproducible example and we will be happy to take a look! Going to close this issue at this time. |
I have actions set up for Chrome and FF testing successfully, however I'm having issues with Edge, with the following yaml:
Set up and Checkout work OK, but then at the "Cypress Run" step:
I tried swapping
yarn
fornpm
but get similar results (complaining that npm ins't starting).Following from this, I'm also wondering, if it's worth setting up tests for different browsers, if they're all Chromium based, what kind of tested features should I expect to pass in one browser but not the other?
Thanks
The text was updated successfully, but these errors were encountered: