chore(deps): remove pre-git and simple-commit-message #26
+0
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
pre-git
The npm package pre-git@3.17.1, configured in the repo, was released on Mar 13, 2018. This was 7 ago and is the latest release of the package. The package is effectively unmaintained.
pre-git
contains multiple unfixable vulnerabilities:postinstall
hook ofpre-git
adds asemantic-release
configuration option, changing the default, ifsimple-commit-message
has been uninstalledsimple-commit-message
simple-commit-message is in the
dependencies
section of pre-git and therefore the two need to be considered together:The npm package simple-commit-message@4.0.3 configured in the repo, was released on Feb 15, 2018 and is outdated.
The latest release of the package simple-commit-message@4.1.3, released on Jul 4, 2021 is effectively unmaintained and has the following issues:
major:
andminor:
. Does not allow the use ofdocs:
,testing:
, etc. used in other Cypress repos.Assessment
At this time, where only emergency fixes are being applied to raise compatibility of the repo to Node.js 22 level,
pre-git
, its hooks andsimple-commit-message
are a hindrance, not a help, to these tasks.pre-git
manipulation of theanalyzeCommits
configuration ofsemantic-release
adds unnecessary complexity to the general update task.Change
In package.json, remove:
config
key containingpre-git
semantic-release
configuration"analyzeCommits": "simple-commit-message"
which then falls back to using the default semantic-release/commit-analyzer which, in turn, uses Angular's commit-message-guidelinesFollow-up
Optionally look at introducing a mainstream and supported replacement for git hooks, such as Husky once other dependencies and configuration details have been successfully updated.
Locally, it may be necessary to remove hooks from
.git/hooks
. This can also be done with: