feat: add type declaration file #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hand roll a type declaration file for `flat.js` that accurately reflects the exported plugin. This resolves type errors when attempting to use `globals` and `recommended` configs in type-checked eslint configs and also aids in autocomplete when typing (as in keyboard button press, not "does it satisfy expected type") properties of the plugin.
|
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MikeMcC399
reviewed
Sep 27, 2025
|
I also successfully tested installing this externally, so with the suggested changes it should be good to go. |
mdmower-csnw
changed the title
Update code style from review Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
jennifer-shehane
approved these changes
Oct 1, 2025
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hand roll a type declaration file for
flat.jsthat accurately reflects the exported plugin. This resolves type errors when attempting to useglobalsandrecommendedconfigs in type-checked eslint configs and also aids in autocomplete when typing (as in keyboard button press, not "does it satisfy expected type") properties of the plugin.Fixes #232
Note: I verified
flat.d.tsis included in the npm package withnpm packand then also verified the types work in another project by installing that package.