Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with unsafe to chain command that is not an action #141

Merged
merged 7 commits into from
May 3, 2024
Merged

fix: issue with unsafe to chain command that is not an action #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93824e4
fix: issue with unsafe to chain command that is not an action
gkorakas-eli Aug 30, 2023
f5eef14
Merge remote-tracking branch 'origin/master' into fix/issue-with-unsa…
gkorakas-eli Sep 20, 2023
b400d55
chore: merge master and apply the fix
gkorakas-eli Sep 20, 2023
8821de0
Merge branch 'master' into fix/issue-with-unsafe-to-chain-command-tha…
gkorakas-eli May 1, 2024
4d239b0
Merge branch 'master' into fix/issue-with-unsafe-to-chain-command-tha…
gkorakas-eli May 2, 2024
edc37e4
chore: add test case that shows the issue back to the code.
gkorakas-eli May 2, 2024
3f22c8e
Merge remote-tracking branch 'origin/fix/issue-with-unsafe-to-chain-c…
gkorakas-eli May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rules/unsafe-to-chain-command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const unsafeToChainActions = [
'check',
'dblclick',
'each',
'focus$',
'focus',
'rightclick',
'screenshot',
'scrollIntoView',
Expand Down Expand Up @@ -130,7 +130,7 @@ const isRootCypress = (node) => {
*/
const isActionUnsafeToChain = (node, additionalMethods = []) => {
const unsafeActionsRegex = new RegExp([
...unsafeToChainActions,
...unsafeToChainActions.map((action) => `^${action}$`),
gkorakas-eli marked this conversation as resolved.
Show resolved Hide resolved
...additionalMethods.map((method) => method instanceof RegExp ? method.source : method),
].join('|'))

Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/unsafe-to-chain-command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ ruleTester.run('action-ends-chain', rule, {
code: 'cy.focused().should("be.visible");',
parserOptions,
},
{
code: 'cy.submitBtn().click();',
parserOptions,
},
],

invalid: [
Expand Down