ci: Use eslint plugin to catch .only in tests #9624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current method using stop-only doesn't really understand javascript syntax and is prone to false positives, particularly on windows. Adapted from cypress-io/cypress-documentation#2194 change. For now punt on linting coffeescript for this rule. Fixes cypress-io#5518
|
Thanks for taking the time to open a PR!
|
|
|
bz2
changed the title
|
We've almost removed all CoffeeScript in this repo, aside from tests that are literally testing how CoffeeScript tests run within Cypress (finishing removing all in the next few weeks). |
bahmutov
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current method using stop-only doesn't really understand javascript syntax and is prone to false positives, particularly on windows.
Adapted from cypress-io/cypress-documentation#2194 change.
For now punt on linting coffeescript for this rule. (Looking at #9125 which is cleaning up some of the old coffeescript migration pieces).
Fixes #5518