-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy other moment properties when wrapping with deprecated warning #9446
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the deprecation warning will be shown when you call Cypress.moment.duration
, etc.
yeah, I did not plan to show a warning when accessing every property, but I don't think it should be blocking this fix. After all, the |
Ok, looked at this again - and now it is showing deprecated warning on any function property recursively in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for fixing this. 🙇♀️
…d Cypress.moment()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated error message to say Cypress.moment
instead of Cypress.moment()
. I think showing individual methods as deprecated in TypeScript is unnecessary for this, so good to go.
Otherwise our build is broken, and any user using these properties would be broken
PR Tasks