fix: do not assume valid file info in error stack line #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
chrisbreiding
requested changes
Nov 4, 2020
chrisbreiding
requested changes
Nov 4, 2020
There was a problem hiding this comment.
The stack traces in the reporter need to be updated so that if the file details don't include the absolute file, it doesn't show the file path as open-able.
|
I opened #9106 to make sure the stack is parsed and displayed correctly in this case, since right now it seems incorrect. |
This was referenced Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
absoluteFileproperty. So we don't even show "open" forhttp:/...(which does not work anyway)How has the user experience changed?
The original error that is causing the crash is shown, not our "cannot replace" error
Scripts without local file no longer have clickable links
PR Tasks