Skip to content

Conversation

@sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Oct 14, 2020

User facing changelog

There was an ambiguity between route2() definitions. cy.route2(string, string) is only resolved as cy.route2(url: string, routeHandler: string). This PR solves this problem.

Additional details

  • Why was this change necessary? => route2() doesn't work as doc says.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => It checks the first argument is a value of HTTP or WebDAV request methods.

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • [N/A] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2020

Thanks for taking the time to open a PR!

@sainthkh sainthkh force-pushed the issue-8729 branch 2 times, most recently from c9057e9 to fde12be Compare October 16, 2020 06:17
@sainthkh sainthkh marked this pull request as ready for review October 16, 2020 07:09
@sainthkh
Copy link
Contributor Author

Flaky failures.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested that this fixes the original issue.

@cypress
Copy link

cypress bot commented Oct 19, 2020



Test summary

8616 0 124 3


Run details

Project cypress
Status Passed
Commit fde12be
Started Oct 19, 2020 5:14 AM
Ended Oct 19, 2020 5:27 AM
Duration 12:30 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane dismissed their stale review October 19, 2020 08:47

Dismissing my previous review

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cy.route2() doesn't work when method is used as the first parameter

3 participants