-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: ambiguity in route2 definitions. #8829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for taking the time to open a PR!
|
c9057e9 to
fde12be
Compare
|
Flaky failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested that this fixes the original issue.
packages/driver/cypress/integration/commands/net_stubbing_spec.ts
Outdated
Show resolved
Hide resolved
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thanks
User facing changelog
There was an ambiguity between route2() definitions.
cy.route2(string, string)is only resolved ascy.route2(url: string, routeHandler: string). This PR solves this problem.Additional details
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?