[WIP] Implement slowTestThreshold Cypress option #870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jennifer-shehane
added
the
stage: needs review
Saibamen
suggested changes
Feb 22, 2019
jennifer-shehane
removed
the
stage: needs review
kuceb
suggested changes
Jan 16, 2020
| @@ -0,0 +1,616 @@ | |||
| _ = require("lodash") | |||
There was a problem hiding this comment.
changes to project.coffee should have its changes merged into project.js and then deleted
| @@ -132,13 +143,14 @@ reporters = { | |||
| } | |||
|
|
|||
| class Reporter | |||
| constructor: (reporterName = "spec", reporterOptions = {}, projectRoot) -> | |||
| constructor: (reporterName = "spec", reporterOptions = {}, projectRoot, slowTestThreshold) -> | |||
There was a problem hiding this comment.
I don't think slowTestThreshold belongs here. I think it should be passed into the mocha constructor as the slow option, which would cut down on the verbosity of adding this option.
Also we need to whitelist sending the _slow prop from the runner to the reporter
kuceb
suggested changes
Jan 16, 2020
kuceb
changed the title
|
Unfortunately we have to close this PR due to inactivity. Please open a new PR to address the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work will address #447 by exposing a new
slowTestThresholdoption in thecypress.json, with a default of 5000ms.I'm not a huge fan of the current implementation. Explicitly passing the
slowTestThresholdvalue to the reporter and hard-setting it to each suite and test group doesn't seem sustainable, but I wanted to get this up for discussion and suggestions.