-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically polyfill window.fetch with XMLHttpRequest #7597
Merged
Merged
Changes from 8 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3f5b69c
automatically polyfill window.fetch with XMLHttpRequest
bahmutov 414cdea
yarn lock
bahmutov 969069f
Merge branch 'develop' into polyfill-fetch
bahmutov 254cc50
Revert "yarn lock"
bahmutov 81e97aa
Merge branch 'develop' into polyfill-fetch
bahmutov 5b579ea
yarn lock for has-binary2
bahmutov eb4ea44
add test polyfill recipe PR
bahmutov f96bdeb
Merge branch 'develop' into polyfill-fetch
bahmutov 2ce27ce
removing eval, using this.XMLHttpRequest to inject proper XMLHttpRequ…
JessicaSachs 8f7c9a9
fixing build
JessicaSachs 89cda9a
dev patches
JessicaSachs 0990b4e
try patching differently, doubt it would work
bahmutov dbbd1a0
merge develop
bahmutov 60063ab
last merge conflict
bahmutov f2e8988
Merge branch 'develop' into polyfill-fetch
bahmutov 89d13a8
Merge branch 'develop' into polyfill-fetch
bahmutov 30bba54
bind fetch polyfill to content window
bahmutov 10ae257
remake unfetch patch
bahmutov 7902378
Merge branch 'polyfill-fetch' of github.com:cypress-io/cypress into p…
bahmutov 2a85c31
add e2e tests for fetch polyfill
bahmutov 9f59760
switch to fetch constructor away from this
bahmutov d6aa5b7
update patch file
bahmutov 4494913
Update packages/driver/README.md
bahmutov 6aee0c7
Merge branch 'develop' into polyfill-fetch
bahmutov 2f2e2b7
removed unfetch from root level
bahmutov d318fb7
adding experimentalFetchPolyfill
bahmutov 135e262
only drop fetch polyfill if experimentalFetchPolyfill is true
bahmutov 4386f7b
enable experimentalFetchPolyfill in the e2e test
bahmutov df44bdb
set state and add test for no polyfill
bahmutov 28f3e03
add experimentalFetchPolyfill to cypress.json schema
bahmutov 62a8b53
update unit test
bahmutov 05e89b1
Merge branch 'develop' into polyfill-fetch
bahmutov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can pretty easily avoid eval + toString and use the correct XMLHttpRequest object if we patch-package and take in the XMLHttpRequest (or content window) reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ughh, but that would be more complex to set up and maintain. Remember the has-binary2 disaster