Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decaffeinate server lib #7588

Merged
merged 4 commits into from
Jun 4, 2020
Merged

chore: decaffeinate server lib #7588

merged 4 commits into from
Jun 4, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 4, 2020

User facing changelog

n/a

Additional details

  • decaffeinated server/lib/**/*.coffee
  • decaffeination of server tests will come in a separate PR

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

DO NOT SQUASH ME

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@flotwig flotwig marked this pull request as ready for review June 4, 2020 17:48
@flotwig flotwig requested review from a team, brian-mann and JessicaSachs and removed request for a team, brian-mann and JessicaSachs June 4, 2020 17:48
@cypress
Copy link

cypress bot commented Jun 4, 2020



Test summary

7519 0 116 0


Run details

Project cypress
Status Passed
Commit fe78574
Started Jun 4, 2020 6:54 PM
Ended Jun 4, 2020 7:00 PM
Duration 06:02 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb
Copy link
Contributor

kuceb commented Jun 4, 2020

go ahead and decaff reporter.coffee, i do not mind

decaffeinate: Rename reporter.coffee from .coffee to .js
decaffeinate: Convert reporter.coffee to JS
… files

decaffeinate: Run post-processing cleanups on reporter.coffee
JessicaSachs
JessicaSachs previously approved these changes Jun 4, 2020
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flotwig flotwig merged commit 29982b4 into develop Jun 4, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
@flotwig flotwig deleted the decaf-server branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants