-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: decaffeinate server lib #7588
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
go ahead and decaff reporter.coffee, i do not mind |
decaffeinate: Rename reporter.coffee from .coffee to .js
decaffeinate: Convert reporter.coffee to JS
… files decaffeinate: Run post-processing cleanups on reporter.coffee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d202b9b
to
7e01f5b
Compare
cleanup
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
n/a
Additional details
except reporter.coffee, since @bkucera has some pending changes for it in feat: support test retries #3968decaffed as wellHow has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?DO NOT SQUASH ME