Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max parameters for cy.viewport() #5882

Merged
merged 6 commits into from
Dec 5, 2019

Conversation

digiink
Copy link
Contributor

@digiink digiink commented Dec 4, 2019

User facing changelog

Cypress tests screens bigger than 4000px wide / high
The max cy.viewport() width and height increased to 8000px.

Additional details

//Problem

cy.viewport(7680, 1601);
Error:
CypressError: cy.viewport() width and height must be between 20px and 4000px.

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 4, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@claassistantio
Copy link

claassistantio commented Dec 4, 2019

CLA assistant check
All committers have signed the CLA.

@flotwig flotwig changed the title Master Increase max parameters for cy.viewport() Dec 4, 2019
@jennifer-shehane
Copy link
Member

@digiink Thanks for the contribution! Could you please sign our CLA? I notice that the author of the commits (Brendan McGinn) does not match the one shown in the GitHub interface (digiink).

This typically means the email address on your GitHub account does not match the email address associated with your commits. Our CLA bot gets confused when they don't match. Here are some solutions to fixing when commits are linked to the wrong user: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

@jennifer-shehane jennifer-shehane merged commit d0eef76 into cypress-io:develop Dec 5, 2019
avallete pushed a commit to avallete/cypress that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cypress on application bigger that 4000px wide
5 participants