Add new warnings and handle unhandled warnings #4493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
reviewed
Jun 18, 2019
| runUrl | ||
| warnings: [{ | ||
| code: "FREE_PLAN_NEARING_MONTHLY_TESTS" | ||
| used: 700 |
There was a problem hiding this comment.
is this test technically over the limit, not nearing it?
There was a problem hiding this comment.
Oh, because of the used amount? I guess, but it doesn't really matter for the test. It's not like we do the math in the test runner.
|
@chrisbreiding Can you resolve conflicts here? |
|
This PR has been superseded by a different one. It needs to refer to the other one... I'll have to find it. Zach did it - but it was generic because we hadn't yet determined the API to use. That has been done now when we released hard usage limits on the services team. |
|
There is a fallthrough for API warnings, and the API now properly formats these ahead of time, so no need for specific messaging. Closing in favor of #456. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4593