Fix bug in proxy where HTTPS_PROXY became 'undefined' #3913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bug causing the failing AppVeyor build, basically the agent was always trying to use a proxy set to string
"undefined"
when no proxy is defined, making the request fail catastrophically every time.Appveyor build: https://ci.appveyor.com/project/cypress-io/cypress-test-example-repos/builds/23690466
The issue causing the actual crash was that
socket.io
was somehow ACK'ing with a circular reference because of the error:This is known to crash socket.io: socketio/socket.io-parser#80
I fixed the proxy issue where
process.env.HTTPS_PROXY
was becoming"undefined"
and added a test, but I'm still unsure as to how this manifested into the circular ack bug we got here.