[WIP] Add error for suites without callback functions #3651
Conversation
lilaconlee
commented
Mar 5, 2019
•
lilaconlee
commented
- Fixes Crash if a "describe" block does not have a callback function #2115
- Addresses Improve Test Runner error experience #3762
This reverts commit 7a94766.
lilaconlee
changed the title
There was a problem hiding this comment.
There's a better and more direct way to test for this. The problem is that this possibly creates an edge case where no tests have been added but not because the suite is missing a callback function. You could likely have an empty suite above the problematic one - or rather you could also have a TypeError that causes this without being directly related to the suites either.
The more solution is to override mocha's function handling of suites and detect whether fn is undefined and immediately throw a precise error there instead of appending this to the bottom of the uncaught error.
Mocha parses the suites at a very specific (and early) time in the process and that area can be handled specifically.
jennifer-shehane
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Unfortunately we have to close this PR due to inactivity. Please open a new PR to address the original issue. |
