test: update font flooding expectations after ServiceWorkerAutoPreload disable - #34752
test: update font flooding expectations after ServiceWorkerAutoPreload disable#34752cursor[bot] wants to merge 2 commits into
Conversation
…d disable Disabling ServiceWorkerAutoPreload on Chrome's browser network path (#34711) issues two Font network requests per navigation instead of one. Update the capture-protocol font flooding system test to expect four requests on chrome while keeping electron at two. Fixes develop pipeline 86214 / system-tests-chrome failure on 9467a6e. Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
CI babysitter: system-tests-chrome failed again on develop 92784efd (pipeline #86228, job 3969512).
Merged commit only updates v8 snapshot cache files (#34755) — same font_flooding_spec.js failure pattern as pipeline #86214 for 9467a6e. Parent develop commit also had system-tests-chrome failing on pipeline 86226.
Sent by Cursor Automation: Monitor cypress/develop for regressions/flake
There was a problem hiding this comment.
CI babysitter flagged failures on develop commit e05fbe457ab4022c18fd7218038936df176585bd (merged via PR #34767 — web-config cleanup, unrelated to font flooding).
Failed jobs (linux-x64):
system-tests-chrome(3972920)system-tests-chrome-force-http1(3972915)
Likely root cause: font_flooding_spec.js — numberOfFontRequests expected 2, got 4 (ServiceWorkerAutoPreload disable regression). Same failure pattern as recent develop pushes (5c783560, 92784efd, b0f01d5).
Pipeline: https://app.circleci.com/pipelines/gh/cypress-io/cypress/86268
This PR appears to address the same issue — please confirm merge readiness.
Sent by Cursor Automation: Monitor cypress/develop for regressions/flake
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3884a87. Configure here.
| const EXPECTED_FONT_REQUESTS_BY_BROWSER = { | ||
| chrome: 4, | ||
| electron: 2, | ||
| } |
There was a problem hiding this comment.
Chrome font count ignores MITM path
Medium Severity
EXPECTED_FONT_REQUESTS_BY_BROWSER always expects 4 font requests for chrome, but the extra requests only occur on the browser network path after ServiceWorkerAutoPreload is disabled. Chrome jobs that set CYPRESS_forceHttp1=true stay on the MITM path, so they still see two requests and this assertion fails.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3884a87. Configure here.
2 participants
Additional details
Develop pipeline #86214 for
9467a6e(#34711) failedsystem-tests-chromeonfont_flooding_spec.js:Parent commit
2043773passedsystem-tests-chrome; disablingServiceWorkerAutoPreloadon Chrome's browser network path causes twoFontnetwork requests per navigation (four across the spec's two visits) instead of one.This PR updates the capture-protocol font flooding system test to expect four requests on chrome while keeping electron at two.
Steps to test
node system-tests/scripts/run.js --glob-in-dir="font_flooding"against a dev build.capture-protocol font floodingpasses for both chrome and electron.How has the user experience changed?
No change
PR Tasks
ServiceWorkerAutoPreloadon the browser network path #34711Note
Low Risk
Test-only expectation and comment updates; no product or runtime behavior changes.
Overview
Fixes a CI regression in the capture-protocol font flooding system test after Chrome’s browser network path started disabling ServiceWorkerAutoPreload (#34709).
The spec no longer asserts a flat 2 font requests for every browser. It uses
EXPECTED_FONT_REQUESTS_BY_BROWSER: 4 for Chrome (twoFontrequests per navigation across two visits) and 2 for Electron (MITM path unchanged). Comments in the protocol stub and spec document why Chrome differs.Reviewed by Cursor Bugbot for commit 3884a87. Bugbot is set up for automated code reviews on this repo. Configure here.