chore: update test-model to not override hooks from runnable #32867
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/do-not-override-hooks
|
| Run status |
|
| Run duration | 18m 45s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
12
|
Pending
|
1098
|
Skipped
|
4
|
Passing
|
26522
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
mschile
approved these changes
Oct 31, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…s from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…s from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
…s from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…s from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…s from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…oks from runnable (#32867)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…s from runnable (#32867)
jennifer-shehane
pushed a commit
that referenced
this pull request
Nov 3, 2025
* chore: updating v8 snapshot cache * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Nov 3, 2025
* chore: updating v8 snapshot cache * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Nov 3, 2025
* chore: updating v8 snapshot cache * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) * index on develop: c57bfe0 chore: update test-model to not override hooks from runnable (#32867) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Test replay in the dashboard reuses the reporter, but has a slightly different configuration than in the cypress monorepo. The cypress monorepo uses webpack with loose babel config that causes it to be possible for subclasses to override super class properties when
useDefineForClassFieldsis set to true. Test replay uses esbuild as its bundler and there's not really a convenient option to replicate this behavior. I think it makes sense to figure the problem at the source which is that we just don't need to override the property in the subclass.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Removes the
hooksfield fromTestto avoid shadowingRunnable’shooks, while continuing to augment hooks in the constructor.packages/reporter/src/test/test-model.ts):Testclass fieldhooks(no longer overridesRunnable’shooks).this.hooksin constructor fromprops.hooksplus synthetic entries ("test body", "studio commands").Written by Cursor Bugbot for commit 9116427. This will update automatically on new commits. Configure here.