misc: Add keyboard shortcut to keyboard shortcut modal for saving studio changes #32864
+188
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
keyboard-dialog-save-studio
|
| Run status |
|
| Run duration | 16m 55s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
131
|
Skipped
|
0
|
Passing
|
5535
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We recently added this keyboard shortcut, but it's not in the keyboard shortcut dialog. https://github.com/cypress-io/cypress-services/pull/12000
Steps to test
yarn cypress:openHow has the user experience changed?
Before
After (Mac)
After (Windows/Linux)
PR Tasks
cypress-documentation?type definitions?Note
Displays the Studio save shortcut in the Keyboard Shortcuts modal with OS-specific keys (⌘+s or Ctrl+s), adds tests, and updates i18n and changelog.
⌘+s(macOS) orCtrl+s(Windows/Linux) inpackages/app/src/navigation/KeyboardBindingsModal.vue.+separators and spacing; computekeyBindingsvia runner platform.packages/app/src/navigation/KeyboardBindingsModal.cy.tsxfor rendering, platform-specific keys, fallback behavior, and modal close events.sidebar.keyboardShortcuts.studioSavetopackages/frontend-shared/src/locales/en-US.json.cli/CHANGELOG.md.Written by Cursor Bugbot for commit ea7d825. This will update automatically on new commits. Configure here.