Skip to content

Conversation

@ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Oct 24, 2025

Additional details

This PR adds more context to the error message shown when cy.prompt fails to download.

Steps to test

How has the user experience changed?

PR Tasks


Note

Improves cy.prompt download error handling by extracting and reporting the underlying (last) error, with new unit tests and changelog entry.

  • Server (cy-prompt):
    • In packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts, unwrap AggregateError and use the last underlying error for reportCyPromptError and returned { error } from initializeCyPromptManager.
  • Tests:
    • Add unit tests to validate handling of direct errors and AggregateError from ensureCyPromptBundle, ensuring the last error is reported/returned (CyPromptLifecycleManager_spec.ts).
  • Changelog:
    • Add entry noting more context in the error message when cy.prompt() fails to download (cli/CHANGELOG.md).

Written by Cursor Bugbot for commit 4b3bf68. This will update automatically on new commits. Configure here.

@ryanthemanuel ryanthemanuel self-assigned this Oct 24, 2025
@ryanthemanuel ryanthemanuel requested a review from mschile October 24, 2025 21:15
@cypress
Copy link

cypress bot commented Oct 24, 2025

cypress    Run #66831

Run Properties:  status check passed Passed #66831  •  git commit 4b3bf68299: Merge branch 'develop' into ryanm/fix/error-message-when-downloading-cy-prompt
Project cypress
Branch Review ryanm/fix/error-message-when-downloading-cy-prompt
Run status status check passed Passed #66831
Run duration 16m 40s
Commit git commit 4b3bf68299: Merge branch 'develop' into ryanm/fix/error-message-when-downloading-cy-prompt
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 132
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5595
View all changes introduced in this branch ↗︎

@MikeMcC399

This comment was marked as resolved.

@ryanthemanuel
Copy link
Collaborator Author

As reported by a user in Discord

https://docs.cypress.io/prompt-download-error

produces a "Page not Found" error

@MikeMcC399 I fixed that in a separate PR in services.

@ryanthemanuel ryanthemanuel merged commit e3d1d5b into develop Oct 25, 2025
90 of 92 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/error-message-when-downloading-cy-prompt branch October 25, 2025 12:19
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot pushed a commit that referenced this pull request Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
jennifer-shehane pushed a commit that referenced this pull request Oct 27, 2025
* chore: updating v8 snapshot cache

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Oct 27, 2025
* chore: updating v8 snapshot cache

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Oct 27, 2025
* chore: updating v8 snapshot cache

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

* index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 4, 2025

Released in 15.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants