-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download #32822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanthemanuel
merged 2 commits into
develop
from
ryanm/fix/error-message-when-downloading-cy-prompt
Oct 25, 2025
Merged
fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download #32822
ryanthemanuel
merged 2 commits into
develop
from
ryanm/fix/error-message-when-downloading-cy-prompt
Oct 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prompt() fails to download
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/fix/error-message-when-downloading-cy-prompt
|
| Run status |
|
| Run duration | 16m 40s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
3
|
|
|
132
|
|
|
0
|
|
|
5595
|
| View all changes introduced in this branch ↗︎ | |
mschile
approved these changes
Oct 24, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
@MikeMcC399 I fixed that in a separate PR in services. |
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ror message shown when cy.prompt() fails to download (#32822)
cypress-app-bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…r message shown when cy.prompt() fails to download (#32822)
jennifer-shehane
pushed a commit
that referenced
this pull request
Oct 27, 2025
* chore: updating v8 snapshot cache * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Oct 27, 2025
* chore: updating v8 snapshot cache * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Oct 27, 2025
* chore: updating v8 snapshot cache * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) * index on develop: e3d1d5b fix: (cy.prompt) add more context to the error message shown when cy.prompt() fails to download (#32822) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR adds more context to the error message shown when cy.prompt fails to download.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Improves cy.prompt download error handling by extracting and reporting the underlying (last) error, with new unit tests and changelog entry.
packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts, unwrapAggregateErrorand use the last underlying error forreportCyPromptErrorand returned{ error }frominitializeCyPromptManager.AggregateErrorfromensureCyPromptBundle, ensuring the last error is reported/returned (CyPromptLifecycleManager_spec.ts).cy.prompt()fails to download (cli/CHANGELOG.md).Written by Cursor Bugbot for commit 4b3bf68. This will update automatically on new commits. Configure here.