fix(dns-cache): prevent local family cache collisions #32403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brian-mann
commented
Sep 2, 2025
| 'test/unit/**/*.ts', | ||
| 'test/integration/**/*.ts' | ||
| ], | ||
| require: '../web-config/node-register', |
There was a problem hiding this comment.
i think there are probably lots of other places where we're incorrectly requiring "web-config" in purely node based tests like this
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
bmann/fix-proxy-cached-net-connect-port
|
| Run status |
|
| Run duration | 09m 49s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
260
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.19%
|
|
|---|---|
|
Untested elements
|
72
|
|
Tested elements
|
57
|
Accessibility
99.45%
|
|
|---|---|
|
Failed rules
|
0 critical
5 serious
0 moderate
1 minor
|
|
Failed elements
|
15
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…hub.com/cypress-io/cypress into bmann/fix-proxy-cached-net-connect-port
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
…hub.com/cypress-io/cypress into bmann/fix-proxy-cached-net-connect-port
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…hub.com/cypress-io/cypress into bmann/fix-proxy-cached-net-connect-port
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanthemanuel
approved these changes
Sep 8, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caching family DNS lookups, we were not properly partitioning
hostwithport, so a previously cached ipv4 family would leak and prevent ipv6 families to different ports from resolving.Maybe related issues, but unable to confirm if they're fixed since there is not a reproducible example or it requires further investigation.
Additional details
Example of a failing test prior to the fix:
Steps to test
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation?type definitions?